Request::getBody(), see #57 #58
Conversation
src/Http/Request.php Outdated
There was a problem hiding this comment.
IMHO rawbody should return rawbody, not parsed body
There was a problem hiding this comment.
? This commit does not change getRawBody() result.
There was a problem hiding this comment.
You're using the same callback, that also parses the JSON for application/json, aren't you?
There was a problem hiding this comment.
Oh, you've added new parameter, sorry :)
| Although it's a nice closure magic, I'm afraid it's gonna be slow, it's not even lazy... I mean, those unnecessary body calls could be easily avoided if type check was extracted outside (like |
| @Majkl578 That's how I originally wanted to do it, but then I though that it is not powerful enough. What if you want to make decision based on something different than Content-Type (e.g. HTTP method)? What if you want to handle all something/* types? That being said I like the simple solution |
|
|
dg force-pushed the master branch 7 times, most recently from 1dc599c to f35d20f Compare 
JanTvrdik force-pushed the request_get_body branch 2 times, most recently from f73e5f9 to 48409af Compare JanTvrdik changed the title | I think that this is now ready to merge. |
JanTvrdik force-pushed the request_get_body branch from 48409af to 48a3e5f Compare 
src/Http/Request.php Outdated
| * @throws InvalidRequestBodyException | ||
| */ | ||
| public function getBody() | ||
| { |
JanTvrdik force-pushed the request_get_body branch from 48a3e5f to 6363c41 Compare 
| @JanTvrdik What about the JSON decode DOS vulnerability? I didn't see anything that would solve it in your code (but I might have missed it of course). |
| @enumag I ignore it the same way everybody in the PHP worlds ignores it. Those few that are concern may replace the body parser for JSON with sth smarter. |
JanTvrdik force-pushed the request_get_body branch from 6363c41 to 1627f10 Compare | BTW: PSR7 calls this method |
| if ($body === NULL) { | ||
| $contentType = $request->getHeader('Content-Type'); | ||
| foreach ($this->bodyParsers as $parserContentType => $parser) { | ||
| if (stripos($contentType, $parserContentType) === 0) { |
There was a problem hiding this comment.
You mean strncasecmp?
There was a problem hiding this comment.
Yes. Its PHP shame that there is no startsWith function.
dg force-pushed the master branch 3 times, most recently from da24b94 to 540335c Compare dg force-pushed the master branch 2 times, most recently from e7c7e2d to bf945f3 Compare dg force-pushed the master branch 3 times, most recently from 9a14e6e to a20fb8f Compare dg force-pushed the master branch 5 times, most recently from 55488bd to 2042d2e Compare dg force-pushed the master branch 2 times, most recently from 4960652 to 5e67add Compare dg force-pushed the master branch 5 times, most recently from 689f4ae to 33aae19 Compare dg force-pushed the master branch 4 times, most recently from 09923de to 02ae846 Compare 5 participants
No description provided.