Test and fix nette/http#15 - Session::configure overrides setHandler set... #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* this commit introduces unit test dependency on redis php extension. Don't know how to avoid it..
Member
There was a problem hiding this comment.
Here should be some check if redis is present (see https://github.com/nette/http/blob/master/tests/Http/Response.setCookie.phpt#L13).
Contributor
| You don't have to install the redis php extension? I didn't know it's installed by default. |
Member
There was a problem hiding this comment.
What about to use $session->setOptions(array('save_handler' => 'files')) - and test can work without redis.
Contributor
| @lexvjatkin ping, can you rework this? |
dg force-pushed the master branch 9 times, most recently from 0bb4336 to 96b498c Compare dg pushed a commit that referenced this pull request Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
...tings
Issue: #15