Fix possible PHP warning "strpos(): Offset not contained in string" #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Thanks |
dg pushed a commit to nette/routing that referenced this pull request Feb 3, 2019
dg pushed a commit to nette/routing that referenced this pull request Feb 3, 2019
dg pushed a commit to nette/routing that referenced this pull request Feb 3, 2019
dg pushed a commit to nette/routing that referenced this pull request Feb 3, 2019
dg pushed a commit to nette/routing that referenced this pull request Feb 10, 2019
dg added a commit to nette/routing that referenced this pull request Feb 13, 2019
(btw fixes nette/application#154 regression)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It happened in some of my failing tests because
$refUrl->getScheme()was empty for whatever reason.Anyway a PHP warning should be fixed.