Fix the incorrect double compare with e,E+,e+ #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @UrielCh PTAL |
| I have the same problem, can you help to check this PR @erav ? |
caimo approved these changes Nov 17, 2021
| @UrielCh Could you please take a look, thank you |
erav approved these changes Nov 17, 2021
goflutterjava approved these changes Dec 2, 2021
| looks good... |
| tell me if you want a new release. |
Yes, I want a new release. If you have time, please release a new version. Thank you :) |
Yes, I want a new release too. If you have time, please release a new version. Thanks, that was helpful. |
@UrielCh Happy Holidays! looking forward to your release :) |
I want a new release too. Thanks. |
Yes, I want a new release. |
| @UrielCh looking forward to your release :). thanks |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
use extra CPU to check if the result can be return as double without precision lostdoes not consider the case of double can appeareE+e+, but the double toString only showsE.Which will lead to an incorrect compare failure.