Simplify version bumping #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Deploy preview for open-api ready! Built with commit 58b565a |
DavidWells approved these changes Sep 17, 2019
ehmicky force-pushed the feature/refactor-bump-version branch from b658bf0 to 58b565a Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This simplifies the logic of
bump-swagger.js. That file updates theswagger.ymlversionfield so it matches thepackage.jsonversionfield. It's run bynpm run version.It basically does the same thing, i.e. looks for the
version:string and replaces it. But it does with a singleString.replace()instead of using streams, making the logic simpler. This also:version:detection (it checks that a version string follows, and that the field is indented)