Skip to content

chore: fix Husky #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2022
Merged

chore: fix Husky #224

merged 1 commit into from
Jan 19, 2022

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jan 14, 2022

See netlify/js-client#659

This fixes how we use Husky with its latest version, as part of @netlify/eslint-config-node.
@ehmicky ehmicky requested a review from ascorbic January 14, 2022 17:58
@ehmicky ehmicky self-assigned this Jan 14, 2022
@ehmicky
Copy link
Contributor Author

ehmicky commented Jan 14, 2022

I am not quite sure why 2 tests fail on macOS, but this seems to be unrelated to this PR 🤔
@kodiakhq kodiakhq bot removed the automerge label Jan 17, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 17, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.
ascorbic
ascorbic previously approved these changes Jan 19, 2022
View reviewed changes
@ehmicky ehmicky requested a review from ascorbic January 19, 2022 15:06
@kodiakhq kodiakhq bot merged commit 61ec6d0 into main Jan 19, 2022
@kodiakhq kodiakhq bot deleted the chore/fix-husky branch January 19, 2022 16:24
@ehmicky
Copy link
Contributor Author

ehmicky commented Jan 19, 2022

This repository seems to have some issues running commitlint:

⧗ input: chore: try this ✖ Please add rules to your `commitlint.config.js` - Getting started guide: https://git.io/fhHij - Example config: https://git.io/fhHip [empty-rules] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint husky - commit-msg hook exited with code 1 (error)

I am looking into it right now. In the meantime, git commit --no-verify can be used to work around it.
@ehmicky
Copy link
Contributor Author

ehmicky commented Jan 19, 2022

Fixed in #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: chore

2 participants

@ehmicky @ascorbic