Skip to content

chore: only do single threaded tests for win #7715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: only do single threaded tests for win #7715

wants to merge 5 commits into from
+18 −15

Conversation

@khendrikse
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)
@khendrikse khendrikse force-pushed the chore/only-single-threaded-for-windows branch from 1949d58 to 3d60ff0 Compare October 17, 2025 14:36
Base automatically changed from chore/fix-long-running-e2e-test-2 to main October 17, 2025 14:38
@github-actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

📊 Benchmark results

Comparing with 8e00eb1

  • Dependency count: 1,031 (no change)
  • Package size: 284 MB (no change)
  • Number of ts-expect-error directives: 380 (no change)
@khendrikse khendrikse marked this pull request as ready for review October 17, 2025 14:58
@khendrikse khendrikse requested a review from a team as a code owner October 17, 2025 14:58
@khendrikse khendrikse requested a review from serhalp October 17, 2025 14:58
serhalp
serhalp reviewed Oct 17, 2025
View reviewed changes
vitest.config.ts
},
// Pin to vitest@1 behavior: https://vitest.dev/guide/migration.html#default-pool-is-forks.
// TODO(serhalp) Remove this and fix hanging `next-app-without-config` fixture on Windows.
pool: 'threads',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to also remove this? the new forks default is supposed to be so much more reliable!

Suggested change
pool: 'threads',
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@khendrikse @serhalp