Skip to content

Conversation

@ashalfarhan
Copy link
Contributor

@ashalfarhan ashalfarhan commented Nov 3, 2021

🎉 Thanks for submitting a pull request! 🎉

Summary

Related to: #3575

This PR will add ability to transfer environment variables from one site to another.
If you want to send env vars from one site to another you can run this sub command.
Given 2 arguments, the basic usage is:

  • If both argument provided, then the first argument will be the sender, and the second one is the destination
  • If only one argument provided, then that will be the destination, and the sender should be current directory site, otherwise it will exit with helpfull error message
  • If there's no env from siteA, then it will exit because nothing to transfer

So users can use this command without open their browser to copy and paste the env vars from one to another


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

koala5

@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 4, 2021
@ashalfarhan ashalfarhan requested a review from a team as a code owner November 4, 2021 13:31
@ashalfarhan
Copy link
Contributor Author

I already run the npm run docs, but it seems the new subcommand doesn't added, am i missed something?

@ashalfarhan
Copy link
Contributor Author

Hi @erezrokah, is there anything that i should change?

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashalfarhan, very sorry for the late review.
This looks good, just one comment.

I'll need to do some manual testing and then we'll be good to go.

@erezrokah erezrokah requested review from lukasholzer and removed request for erezrokah November 19, 2021 10:38
@ashalfarhan
Copy link
Contributor Author

Hi @erezrokah, @lukasholzer.
Are you guys already trying to test this PR locally?

@lukasholzer
Copy link
Contributor

@ashalfarhan sorry for the late check in on that one! We are currently on getting a huge refactoring over the finishing line today or tomorrow: #3717 as we are going to remove the oclif framework from the CLI.

So I would like to get this over the line first before adding new features. As said the timeline for this will be today or tomorrow as we want to have a large enough window before the Christmas brake to test it properly.

If that is merged I could offer you to update the PR on the oclif removal and do then manual testing on it if you want so.

@erezrokah erezrokah removed the request for review from lukasholzer December 20, 2021 14:11
@ashalfarhan
Copy link
Contributor Author

ashalfarhan commented Dec 20, 2021

@ashalfarhan sorry for the late check in on that one! We are currently on getting a huge refactoring over the finishing line today or tomorrow: #3717 as we are going to remove the oclif framework from the CLI.

So I would like to get this over the line first before adding new features. As said the timeline for this will be today or tomorrow as we want to have a large enough window before the Christmas brake to test it properly.

If that is merged I could offer you to update the PR on the oclif removal and do then manual testing on it if you want so.

Well, I'm creating another for PR for addressing this feature #3876
Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature code contributing to the implementation of a feature and/or user facing functionality

3 participants