- Notifications
You must be signed in to change notification settings - Fork 431
feat(command-env): add transfer subcommand #3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into feat/env-transfer
| I already run the npm run docs, but it seems the new subcommand doesn't added, am i missed something? |
| Hi @erezrokah, is there anything that i should change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashalfarhan, very sorry for the late review.
This looks good, just one comment.
I'll need to do some manual testing and then we'll be good to go.
| Hi @erezrokah, @lukasholzer. |
| @ashalfarhan sorry for the late check in on that one! We are currently on getting a huge refactoring over the finishing line today or tomorrow: #3717 as we are going to remove the oclif framework from the CLI. So I would like to get this over the line first before adding new features. As said the timeline for this will be today or tomorrow as we want to have a large enough window before the Christmas brake to test it properly. If that is merged I could offer you to update the PR on the oclif removal and do then manual testing on it if you want so. |
Well, I'm creating another for PR for addressing this feature #3876 |
🎉 Thanks for submitting a pull request! 🎉
Summary
Related to: #3575
This PR will add ability to transfer environment variables from one site to another.
If you want to send env vars from one site to another you can run this sub command.
Given 2 arguments, the basic usage is:
siteA, then it will exit because nothing to transferSo users can use this command without open their browser to copy and paste the env vars from one to another
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)