Fix: Use 404.html page in publish folder #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In Netlify, you can set a custom 404 page by putting a 404.html file into the publish folder (e.g., public or whatever is specified in netlify.toml). Until now, this custom 404 page was not picked up by netlify dev. For it to work in netlify dev, the custom 404.html file had to be in the root folder. This commit makes the behavior of netlify dev consistent with Netlify in production by using the custom 404.html page in the publish folder. Fixes: netlify#1158
| Deploy request for cli accepted. Accepted with commit cccf547 https://app.netlify.com/sites/cli/deploys/5f4809e73c62050007ef4dfc |
erezrokah approved these changes Aug 30, 2020
FinnWoelm added a commit to netlify/next-on-netlify that referenced this pull request Sep 6, 2020
Netlify dev now picks up the custom 404.html from the publish folder (matching the behavior of deployment on Netlify). We can remove the workaround where we copied the 404.html to the project root. Fix in netlify/cli: netlify/cli#1159
FinnWoelm added a commit to netlify/next-on-netlify that referenced this pull request Sep 6, 2020
- Add support for base64 encoding in responses returned from SSR pages and API endpoints - Reduce the number of rewrites generated by skipping SSG & HTML pages with static routing. These pages are routed automatically by Netlify ([#26](#26)) - Limit the default number of lines of build output to 50. More or fewer lines can be shown by running `next-on-netlify` with the option `--max-log-lines XX`. See `next-on-netlify --help` and [this comment](#26 (comment)). - Remove workaround for making `404.html` work with `netlify dev`. The workaround is no longer required because [`netlify dev` has been patched](netlify/cli#1159).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
- Summary
In Netlify, you can set a custom 404 page by putting a 404.html file inside the publish folder (e.g., public or whatever is specified in netlify.toml).
Until now, this custom 404 page was not picked up by netlify dev. For it to work in netlify dev, the custom 404.html file had to be in the root folder.
This PR makes the behavior of netlify dev consistent with Netlify in production by using the custom 404.html page in the publish folder.
Fixes: #1158
- Test plan
I first added a test to tests/command.dev.test.js. I ran the test and confirmed that it failed. Then I implemented the fix. I reran the test and the test passed.
I ran npm run test and everything came back green.
- Description for the changelog
Fix: Use 404.html page in publish folder (#1158)
- A picture of a cute animal (not mandatory but encouraged)