Skip to content

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Nov 22, 2021

Part of #3741

This drops support for Node 10. This should not be a breaking change for sites (see explanation in #3741), but it requires making a major release.

This PR only drops the version in engines.node. Some of the code can be optimized thanks to dropping Node 10, but I will do this in a separate PR.

I will also fix the branch protection rule right before merging this.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅
Copy link
Contributor

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@ehmicky ehmicky merged commit ae8224d into main Nov 24, 2021
@ehmicky ehmicky deleted the chore/node-12 branch November 24, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore work needed to keep the product and development running smoothly

2 participants