Closes #20900: Add FilterSet-aware CustomField form fields #20992
+13 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add a `for_filterset_form` flag to `CustomField.to_form_field()` to allow building form fields/widgets tailored specifically for FilterSet forms. Update NetBoxModelFilterSetForm to use this flag for improved custom field filtering. Fixes netbox-community#20900
jeremystretch requested review from a team and jnovinger and removed request for a team 
jnovinger approved these changes Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes: #20900
This PR improves the UX for filtering on Selection-type custom fields by allowing users to pick multiple values in the filter form, while keeping the field single-valued everywhere else.
for_filterset_formflag toCustomField.to_form_field()so filter forms can request filter-specific field/widget behavior.for_filterset_form=True, renderSelectioncustom fields using a multi-select field/widget (without changing create/edit/bulk-edit behavior).NetBoxModelFilterSetFormto passfor_filterset_form=Truewhen constructing custom-field-backed filter fields.