- Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
netboxstatus: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: housekeepingChanges to the application which do not directly impact the end userChanges to the application which do not directly impact the end user
Milestone
Description
Proposed Changes
Either rename views.generic.BulkImportView to views.generic.ImportView, or alter the urlpatterns to name='*_bulk_import'.
For backwards compatability, the BulkView could be an alias or urlpattern name='*_import' could be supported until a next major release.
I believe that renaming the urlpattern is better, since an import action could add only a single object (i.e. with a plugin connecting to an external service).
In this case, the NetBoxModelImportForm should probably also be renamed to NetBoxModelBulkImportForm.
Justification
The current implementation is inconsistent; the other bulk urlpatterns are named _bulk_add, _bulk_edit, _bulk_rename and _bulk_delete.
See for instance netbox/dcim/urls.py and netbox/ipam/urls.py.
Metadata
Metadata
Assignees
Labels
netboxstatus: acceptedThis issue has been accepted for implementationThis issue has been accepted for implementationtype: housekeepingChanges to the application which do not directly impact the end userChanges to the application which do not directly impact the end user