Skip to content

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Nov 5, 2024

Related Issue: #1331

New Behavior

  • Nginx Unit trusts proxies on RFC1918 networks to set the X-Forwarded-* headers

Contrast to Current Behavior

  • IP of proxy is shown in the logs

Discussion: Benefits and Drawbacks

  • Easier request tracking

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Trust proxies on RFC1918 networks to set X-Forwarded-* headers

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.
@tobiasge tobiasge requested a review from cimnine November 5, 2024 12:16
Simplifies the listener configuration by using a wildcard for the IP and adds a forwarded section that trusts all proxies on RFC1918 networks.
@tobiasge tobiasge merged commit 7ccd618 into netbox-community:develop Nov 7, 2024
9 checks passed
@tobiasge tobiasge deleted the 1331-forwarded-for branch November 7, 2024 08:07
@tobiasge tobiasge mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants