Skip to content

Revert fixes #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Revert fixes #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2455598
Revert "Fix CI build failure and tag creation issues in release workf…
antonym Jun 12, 2025
83032a8
Revert "Fix CI build failure in release workflow (#89)"
antonym Jun 12, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
fetch-depth: '0'
fetch-tags: true

- name: Set env variables
run: |
Expand Down Expand Up @@ -74,11 +73,7 @@ jobs:
IMAGE_RELEASE=$(echo ${IMAGE_INFO} | jq -r '.Labels.build_version' | awk '{print $3}')
IMAGE_VERSION=$(echo ${IMAGE_RELEASE} | awk -F'-nbxyz' '{print $1}')
NB_RELEASE_NUMBER=$(echo ${IMAGE_RELEASE} | awk -F'-nbxyz' '{print $2}')
if git rev-parse --verify "refs/tags/${IMAGE_RELEASE}" >/dev/null 2>&1; then
TAG_SHA=$(git rev-list -n 1 ${IMAGE_RELEASE})
else
TAG_SHA=""
fi
TAG_SHA=$(git rev-list -n 1 ${IMAGE_RELEASE})
if [ -z "${MULTIDIGEST}" ] || [ "${MULTIDIGEST}" == "null" ]; then
echo "**** No existing container build found, assuming first build ****"
VERSION_TAG=${WEBAPP_RELEASE}-nbxyz1
Expand Down Expand Up @@ -142,20 +137,8 @@ jobs:
ghcr.io/netbootxyz/netbootxyz:${{ env.VERSION_TAG }}
labels: ${{ steps.meta.outputs.labels }}

- name: Check if tag exists
if: steps.version_check.outcome == 'success' && steps.version_check.conclusion == 'success'
id: check_tag
run: |
if git rev-parse --verify "refs/tags/${{ env.VERSION_TAG }}" >/dev/null 2>&1; then
echo "Tag ${{ env.VERSION_TAG }} already exists, skipping tag creation"
echo "tag_exists=true" >> $GITHUB_OUTPUT
else
echo "Tag ${{ env.VERSION_TAG }} does not exist, will create"
echo "tag_exists=false" >> $GITHUB_OUTPUT
fi

- name: Bump version and push tag
if: steps.version_check.outcome == 'success' && steps.version_check.conclusion == 'success' && steps.check_tag.outputs.tag_exists == 'false'
if: steps.version_check.outcome == 'success' && steps.version_check.conclusion == 'success'
id: tag_version
uses: anothrNick/github-tag-action@1.73.0
env:
Expand Down