Skip to content

Conversation

WhoIsSethDaniel
Copy link
Contributor

msgpack consistently errors out saying it cannot convert an 'int to a
string'. If you change it to an int it works as expected.

msgpack consistently errors out saying it cannot convert an 'int to a string'. If you change it to an int it works as expected.
@zchee
Copy link
Member

zchee commented Nov 6, 2020

@WhoIsSethDaniel sorry for late, I'll check and test, but currently go-client have CI problem. I want to fix CI first, Could you waiting?

@WhoIsSethDaniel
Copy link
Contributor Author

@WhoIsSethDaniel sorry for late, I'll check and test, but currently go-client have CI problem. I want to fix CI first, Could you waiting?

Yes I can wait

@zchee zchee self-requested a review November 8, 2020 23:05
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #80 (c03abed) into master (42f62bc) will not change coverage.
The diff coverage is 0.0%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #80 +/- ## ====================================== Coverage 57.4% 57.4% ====================================== Files 11 11 Lines 2124 2124 ====================================== Hits 1221 1221 Misses 769 769 Partials 134 134 
Impacted Files Coverage Δ
nvim/helpers.go 76.9% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f62bc...c03abed. Read the comment docs.

@zchee
Copy link
Member

zchee commented Nov 11, 2020

@WhoIsSethDaniel fixed CI. Could you write a test case as much as possible?

@zchee
Copy link
Member

zchee commented Nov 11, 2020

@WhoIsSethDaniel never mind. I found it type is int in Neovim doc :help.
Will merge and I'll write testcase.

@zchee zchee merged commit 87c0cc7 into neovim:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants