wip(msgpack): handle Nil strings #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
for nvim minor verion 9, no commands are returned for nvim minor version 10, three are returned currently, for nightly builds, four are returend
neovim ships with default keybindings that may change per verison. the tests, prior to this change, included these default key mappings which make the tests fragile with each release. keeping a list of default commands should be outside the scope of this library. this change removes assertions against the entire set of keymaps returned by `nvim_get_keymap` and only verifies the desired keymap has been added and then removed.
using the colors described here rather than the color map https://neovim.io/doc/user/syntax.html#ctermbg
v0.11 changed the way that messages are broadcast from only to those who are subscribed, to all channels. this test, as it's written, doesn't make sense in that scenario. snippet from release notes: > vim.rpcnotify(0) and rpcnotify(0) broadcast to ALL channels. Previously > they would "multicast" only to subscribed channels (controlled by > nvim_subscribe()). Plugins and clients that want "multicast" behavior > must now maintain their own list of channels.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #184 +/- ## ======================================= - Coverage 83.3% 83.1% -0.2% ======================================= Files 14 14 Lines 3132 3134 +2 ======================================= - Hits 2610 2607 -3 - Misses 522 527 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
all of the listed go versions prior to this change are no longer supported. this bumps to more recent versions.
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I made another change that I'm worried might not be the right direction:
Here
https://github.com/neovim/go-client/pull/184/files#diff-4686cdf50ccf547850a2e89191f11c343519caef6fd7718fd73b7a1480606bd0L3843
I moved away from using the color map based on https://neovim.io/doc/user/syntax.html#ctermbg. I'm not sure if the ctermbg / ctermfg are expected to work with the RGB colors that are in the color map, or if maybe the color map has been enhanced since v0.9? I'm not sure if I'm avoiding the issue with this fix.