Add logic to propagate CE-cancelation via channels #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds a `CancelTemplate` for users to specify a method that should be used for cancelation purposes. This LSP method is implemented automatically. When invoked, the server looks up the list of running calls it contains, and cancels the corresponding one. On the client side, stubs are automatically wired so that canceling a request in flight leads to a cancelation request propagating to the server with the corresponding CallId.
Baccata commented Aug 8, 2022
| @@ -1,294 +0,0 @@ | |||
| // package jsonrpclib | |||
There was a problem hiding this comment.
clean-up, as I don't think I'll add a Future-based implementation. I'd be willing to make it easier to mount endpoints implemented against Future into a pure channel though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds a
CancelTemplatefor users to specify a method that shouldbe used for cancelation purposes. This LSP method is implemented
automatically. When invoked, the server looks up the list of running
calls it contains, and cancels the corresponding one.
On the client side, stubs are automatically wired so that canceling a
request in flight leads to a cancelation request propagating to the
server with the corresponding CallId.