Skip to content

Conversation

@larsoner
Copy link
Contributor

I think a requirement on pybind11 might have been errantly added in #68. Perhaps a copy-paste error from adapting another project's pyproject.toml? I don't see it used anywhere but maybe I missed it...

Feel free to close if I'm wrong, this is basically a question-as-PR, I am working on a conda-forge recipe and was surprised to see pybind11 in the host reqs.

@larsoner
Copy link
Contributor Author

... okay for me to update CIs to use Python 3.12 in this PR as well?

Copy link
Owner

@nbara nbara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @larsoner, yes this was leftover from another project! Thanks for flagging

@nbara
Copy link
Owner

nbara commented Nov 19, 2024

... okay for me to update CIs to use Python 3.12 in this PR as well?

absolutely

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.86%. Comparing base (e220ac7) to head (8346c7c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #81 +/- ## ========================================== + Coverage 81.83% 82.86% +1.02%  ========================================== Files 24 25 +1 Lines 2637 2813 +176 ========================================== + Hits 2158 2331 +173  - Misses 479 482 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@larsoner
Copy link
Contributor Author

Ready for review/merge from my end. Token can be added whenever you want. It actually seems to be working without it, maybe because this is a personal repo not an org repo? Not sure 🤷

@nbara nbara changed the title MAINT: Dont require pybind [MAINT] Dont require pybind + test python 3.12 Nov 19, 2024
@nbara nbara merged commit c9128f2 into nbara:master Nov 19, 2024
7 checks passed
@nbara
Copy link
Owner

nbara commented Nov 19, 2024

Thanks @larsoner

@larsoner larsoner deleted the bind branch November 19, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants