Skip to content

Conversation

@elena-p
Copy link

@elena-p elena-p commented Jan 23, 2019

No description provided.

@farfromrefug
Copy link
Member

@elena-p may i ask why you decided to rename Img to NSImg?

@elena-p
Copy link
Author

elena-p commented Jan 24, 2019

Hi @farfromrefug,

I should have added a description, sorry.

When I tried with the Img element <Img imageUri="..."></Img> I got the following error:
Template parse errors: Void elements do not have end tags "Img"

Trying with self closing Img or without closing of the element at all, didn't generate errors, but the image was not shown.

If you prefer another name, or wish to follow the angular naming conventions, I will update the selector.

@farfromrefug
Copy link
Member

@elena-p ok it is actually due to the fact that img is reserved and that html img is special in the sense that it does not require a end tag. So same thing in angular.

Your name is good for me

@farfromrefug farfromrefug merged commit 1587faf into nativescript-community:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants