Skip to content

Conversation

@darklight365
Copy link

Allow the Angular plugin seed to be generic so that it can be reused by other plugins within the nativescript-community repo.

be reused in other plugin libraries.
@farfromrefug
Copy link
Member

@darklight365 thanks. I dont really like the copy rules for webpack for modules. My issue is that it modifies the demo-ng submodule each time which is bad (would tell you to commit your changes afterward).

now i know also that the way i was doing it with ../../../demo-snippets/ng/... is not good either. I am not thinking it should be @nativescript-community/template-snippet/ng/...`

Also you cant remove @nativescript-community/template-snippet from the deps! It is very important to have it. For some plugins @nativescript-community/template-snippet is also seen as a true N plugin with native code. Removing it will break many things.

@darklight365
Copy link
Author

@farfromrefug - I was also not a fan of the copy rule, but a way to possibly solve that would be to gitignore the app/plugin folder then it would not consider changes made to that on commit.

To note: I did attempt to make use of the @nativescript-community/template-snippet instead of adding a copy rule but that unfortunately did not work. Which is why I went with the copy rule approach. You are welcome to explore that yourself as well to see if you can get that approach to work.

I only removed the @nativescript-community/template-snippet dependency since it would appear to no longer be required (within the confines of the seed project). I'm fairly certain it can be left in place if there is a need for it.

@farfromrefug
Copy link
Member

@darklight365 thanks for testing all that. Will have to have a stab at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants