Skip to content

Conversation

@vhdirk
Copy link

@vhdirk vhdirk commented Feb 2, 2022

I could not get the demo in https://github.com/nativescript-community/ui-mapbox to work without these change

@keerl
Copy link
Collaborator

keerl commented Feb 2, 2022

You should be able to overwrite the existing manifest by putting it in (and/or creating) the demo-snippets/App_Resources/Android/src/main directory. That way we don't have to modify the manifest for the actual demo project because that is a shared demo used across many plugins.

@vhdirk
Copy link
Author

vhdirk commented Feb 2, 2022

Ah, cool. that works, indeed.

@vhdirk vhdirk closed this Feb 2, 2022
@vhdirk vhdirk deleted the fixManifest branch February 2, 2022 16:12
@vhdirk
Copy link
Author

vhdirk commented Feb 2, 2022

Still, android:exported="true" is needed though. It will not merge manifests if that's not present, it seems.

@keerl
Copy link
Collaborator

keerl commented Feb 2, 2022

That doesn't make sense, it just does a straight-up copy of the file. I don't see a reason why that wouldn't work. Have you done a ns clean and tried running it again? It might need a fresh re-copy if it has been changed.

@vhdirk
Copy link
Author

vhdirk commented Feb 2, 2022

I ran npm clean, ns clean and npm run demo.ng.clean; none of which do the trick. Did I put the AndroidManifest in the correct spot? https://github.com/nativescript-community/ui-mapbox/pull/65/files

@keerl
Copy link
Collaborator

keerl commented Feb 2, 2022

Move the file up one level, it shouldn't be in the res directory.

@vhdirk
Copy link
Author

vhdirk commented Feb 2, 2022

Oh, thanks a lot! Not sure how it ended up in res.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants