Added syncAllFiles option #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| "description": "Whether the app should be rebuild before start.", | ||
| "default": true | ||
| }, | ||
| "syncAllFiles": { |
There was a problem hiding this comment.
Would you mind we rename this to "syncModules", syncModuleFiles, syncNodeModules... or something like that.
syncAllFiles is too generic and one needs to read the description to know what that does. the CLI flag is holding off the same I think.
There was a problem hiding this comment.
syncNodeModules sounds good. We have not documented this option in CLI, still it could affect existing users of VSC extension. Do you want this change in release?
There was a problem hiding this comment.
yep we can rename this before releasing. to avoid "braking change" it later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.