fix: use strict versions for all dependencies #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently build of the extension fails as the versions of dependencies and devDependencies are not hardcoded and we receive version of `@types/lodash` that is incompatible with the TypeScript we are using. For `@types/lodash` we have the following dist-tags: ``` { latest: '4.14.122', 'ts2.0': '4.14.50', 'ts2.1': '4.14.56', 'ts2.2': '4.14.112', 'ts2.3': '4.14.112', 'ts2.4': '4.14.112', 'ts2.5': '4.14.112', 'ts2.6': '4.14.121', 'ts2.7': '4.14.121', 'ts2.8': '4.14.122', 'ts2.9': '4.14.122', 'ts3.0': '4.14.122', 'ts3.1': '4.14.122', 'ts3.2': '4.14.122', 'ts3.3': '4.14.122', 'ts3.4': '4.14.122' } ``` In our case we are using TypeScript 2.6.2, so set the version of `@types/lodash` to 4.14.121. Also set strict versions for all other dependencies (based on what has been installed in my local `node_modules` dir). 
ghost assigned 
DimitarTachev approved these changes Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently build of the extension fails as the versions of dependencies and devDependencies are not hardcoded and we receive version of
@types/lodashthat is incompatible with the TypeScript we are using.For
@types/lodashwe have the following dist-tags:In our case we are using TypeScript 2.6.2, so set the version of
@types/lodashto 4.14.121.Also set strict versions for all other dependencies (based on what has been installed in my local
node_modulesdir).