refactor(data): add scoped management of Session objects #71
Conversation
nanotaboada commented Apr 7, 2024
nanotaboada commented - https://docs.sqlalchemy.org/en/14/orm/contextual.html#sqlalchemy.orm.scoped_session
| Code Climate has analyzed commit 29a8f92 and detected 0 issues on this pull request. View more on Code Climate. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #71 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 28 28 ========================================= Hits 28 28 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| DATABASE_URL = "sqlite:///./data/players-sqlite3.db" | ||
| | ||
| engine = create_engine(DATABASE_URL, connect_args={"check_same_thread": False}) | ||
| OrmSession = scoped_session(sessionmaker(autocommit=False, autoflush=False, bind=engine)) |
Check warning
Code scanning / Pylint (reported by Codacy)
Constant name "OrmSession" doesn't conform to UPPER_CASE naming style
| OrmSession = sessionmaker(autocommit=False, autoflush=False, bind=engine) | ||
| DATABASE_URL = "sqlite:///./data/players-sqlite3.db" | ||
| | ||
| engine = create_engine(DATABASE_URL, connect_args={"check_same_thread": False}) |
Check warning
Code scanning / Pylint (reported by Codacy)
Constant name "engine" doesn't conform to UPPER_CASE naming style
| def get_player_by_id( | ||
| player_id: int = Path(..., title="The Id of the Player"), | ||
| db_session: Session = Depends(get_db_session) | ||
| orm_session: Session = Depends(get_orm_session) |
Check warning
Code scanning / Pylint (reported by Codacy)
Wrong hanging indentation before block (add 4 spaces).
| ) | ||
| def get_players( | ||
| db_session: Session = Depends(get_db_session) | ||
| orm_session: Session = Depends(get_orm_session) |
Check warning
Code scanning / Pylint (reported by Codacy)
Wrong hanging indentation before block (add 4 spaces).
| def get_player_by_squad_number( | ||
| squad_number: int = Path(..., title="The Squad Number of the Player"), | ||
| db_session: Session = Depends(get_db_session) | ||
| orm_session: Session = Depends(get_orm_session) |
Check warning
Code scanning / Pylint (reported by Codacy)
Wrong hanging indentation before block (add 4 spaces).
