Convert RegExp objects to Sets #8
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I think it is better to not rely on any RegExp library, especially for something as simple as detecting whether a string is in a given set of strings, or whether a given number is within a given set of numbers. Thus, I converted this library to use
Set.hasinstead ofRegExp.test.(I would think Sets would be more efficient anyway, although it doesn't look like this library prioritizes efficiency in all places)
I am porting this library to Lua and this is one of the changes I had to make. I thought I might as well make it available for this version as well, if others could stand to benefit.