input regexp #2
Closed
input regexp #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
i didn't test
mysticatea requested changes Apr 29, 2018
src/index.ts Outdated
| options?: RegExpParser.Options, | ||
| ): AST.RegExpLiteral { | ||
| return new RegExpParser(options).parseLiteral(source) | ||
| return new RegExpParser(options).parseLiteral(source instanceof RegExp ? `/${source.source}/${source.flags}` : source) |
There was a problem hiding this comment.
`/${source.source}/${source.flags}`
This is exact what RegExp#toString() does. I think you can use String(source) merely.
src/index.ts Outdated
| export function parseRegExpLiteral( | ||
| source: string, | ||
| export function parseRegExpLiteral<T>( | ||
| source: T extends RegExp ? RegExp : string, |
There was a problem hiding this comment.
I think that <T> is redundant. You can use source: string | RegExp,.
mysticatea added a commit that referenced this pull request Jun 16, 2018
bluelovers added a commit to bluelovers/regexpp that referenced this pull request May 7, 2019
* mysticatea/master: 2.0.1 Fix: follow tc39/ecma262#910 (refs eslint/eslint#10861) 2.0.0 2.0.0-beta.0 Update: Unicode version to 11 Breaking: replace Disjunction node by Alternative node Docs: update README.md Chore: trivial Chore: follow up mysticatea#2 Update: parseRegExpLiteral supports RegExp object Chore: coverage Chore: upgrade deps Fix: location of quantifier (fixes mysticatea#3) New: add visitor Chore: update eslint config Breaking: drop Node.js 4 support # Conflicts: # .eslintignore # .eslintrc.yml # package.json # src/index.ts # src/parser.ts # test/fixtures/parser/literal.ts # tsconfig.json
ota-meshi pushed a commit to ota-meshi/regexpp that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
i didn't test