no-process-env: support custom error message "use the env wrapper" #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
closes mysticatea#318 (no-process-env: accept a custom error message)
devinrhode2 commented Jan 23, 2022
| "node/no-process-env": [ | ||
| "error", | ||
| { | ||
| "customMessage": "Use the env wrapper instead." |
There was a problem hiding this comment.
I made this sample message deliberately bad to drive the point that users need to edit it for their use case.
In my case it'll be something like: "Use safeEnv from 'src/env' instead."
|
We switched to it in eg. Try that module out and if it isn't fixed there, then open a new PR in that project. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is the first time I've ever touched eslint rule stuff, but I feel pretty good about this change, and was able to maintain the 100% test coverage on this rule.