Tags: mysql/mysql-server
Tags
Update License Book Approved-by: Balasubramanian Kandasamy <balasubramanian.kandasamy@oracle.com>
Merge branch 'mysql-8.0' into mysql-8.4 Change-Id: Iab44436a19cded67f8811765c8672195981f6179 (cherry picked from commit 54d50afb5bf6c9443f89f12f94215e0854c8bb51)
Updating man pages from Docs Approved by: Erlend Dahl <erlend.dahl@oracle.com> Change-Id: Ica8d31df8a0bcda2f94c98dea65266f1a2b8d06f (cherry picked from commit 3ec252a6414cd5b60f0fa9d1fc157ad9e6096797)
Merge branch 'mysql-8.0' into mysql-8.4 Change-Id: Iab44436a19cded67f8811765c8672195981f6179 (cherry picked from commit 54d50afb5bf6c9443f89f12f94215e0854c8bb51)
Updating man pages from Docs Approved by: Erlend Dahl <erlend.dahl@oracle.com> Change-Id: Ica8d31df8a0bcda2f94c98dea65266f1a2b8d06f (cherry picked from commit 3ec252a6414cd5b60f0fa9d1fc157ad9e6096797)
Bug#35665117 Outdated Documentation Links in Source For URL in the source code that points to the mysql.com domain, replace http with https. For URL pointing to the MySQL reference manual, aka starting with dev.mysql.com/doc/refman/, remove the version number, which gets outdated. For example: http://dev.mysql.com/doc/refman/8.0/en/source-installation.html is replaced with https://dev.mysql.com/doc/refman/en/source-installation.html Change-Id: I99bb8e55c4b172211d898d81a8586b799e67e5a2
Bug#35665117 Outdated Documentation Links in Source For URL in the source code that points to the mysql.com domain, replace http with https. For URL pointing to the MySQL reference manual, aka starting with dev.mysql.com/doc/refman/, remove the version number, which gets outdated. For example: http://dev.mysql.com/doc/refman/8.0/en/source-installation.html is replaced with https://dev.mysql.com/doc/refman/en/source-installation.html Change-Id: I99bb8e55c4b172211d898d81a8586b799e67e5a2
Bug#37882398 [InnoDB] Assertion failure: ddl0file-reader.cc:193: m_ptr + data_size < m_bounds.second PROBLEM: 1. After the fix for the "Bug #37233273 - DDL buffer increase has out of control memory usage", this assertion was seen. 2. The fix for Bug #37233273 basically accounts for meta data as part of innodb_ddl_buffer_size buffer which reduces the number of rows which can fit in a key buffer block while adding an index. 3. When the key buffer is full, the records in the key buffer are added to the temporary file, which constitutes a chunk. This chunk is smaller than actual key buffer size. 4. The offsets of each chunk is recorded in a queue. The chunks sizes are multiples of the sector size (4KB). 5. When merging the two chunks into one sorted chunk, we read from this queue. 6. Another bug, Bug#36444172 "Regression in 8.0.27+ related to Parallel DDL IO Amplification" read the sizes of the first two chunks from the queue and set a limit on the input buffer based on the size of the first two chunks. 7. In our case, the sizes of the first two chunks were smaller compared to the subsequent chunk sizes. 8. Therefore, while reading the rows from subsequent chunks we hit this imit on the input buffer. FIX: 1. Each ddl thread is allocated a certain amount of input buffer based on the number of scan threads and the DDL buffer size. We should use this allocation as the limit for the input buffer while reading the rows from a chunk. Change-Id: Iba4a224c9973bea2b5a6a2288a23473dd2c21b06
Bug#37882398 [InnoDB] Assertion failure: ddl0file-reader.cc:193: m_ptr + data_size < m_bounds.second PROBLEM: 1. After the fix for the "Bug #37233273 - DDL buffer increase has out of control memory usage", this assertion was seen. 2. The fix for Bug #37233273 basically accounts for meta data as part of innodb_ddl_buffer_size buffer which reduces the number of rows which can fit in a key buffer block while adding an index. 3. When the key buffer is full, the records in the key buffer are added to the temporary file, which constitutes a chunk. This chunk is smaller than actual key buffer size. 4. The offsets of each chunk is recorded in a queue. The chunks sizes are multiples of the sector size (4KB). 5. When merging the two chunks into one sorted chunk, we read from this queue. 6. Another bug, Bug#36444172 "Regression in 8.0.27+ related to Parallel DDL IO Amplification" read the sizes of the first two chunks from the queue and set a limit on the input buffer based on the size of the first two chunks. 7. In our case, the sizes of the first two chunks were smaller compared to the subsequent chunk sizes. 8. Therefore, while reading the rows from subsequent chunks we hit this imit on the input buffer. FIX: 1. Each ddl thread is allocated a certain amount of input buffer based on the number of scan threads and the DDL buffer size. We should use this allocation as the limit for the input buffer while reading the rows from a chunk. Change-Id: Iba4a224c9973bea2b5a6a2288a23473dd2c21b06
Bug#37882398 [InnoDB] Assertion failure: ddl0file-reader.cc:193: m_ptr + data_size < m_bounds.second PROBLEM: 1. After the fix for the "Bug #37233273 - DDL buffer increase has out of control memory usage", this assertion was seen. 2. The fix for Bug #37233273 basically accounts for meta data as part of innodb_ddl_buffer_size buffer which reduces the number of rows which can fit in a key buffer block while adding an index. 3. When the key buffer is full, the records in the key buffer are added to the temporary file, which constitutes a chunk. This chunk is smaller than actual key buffer size. 4. The offsets of each chunk is recorded in a queue. The chunks sizes are multiples of the sector size (4KB). 5. When merging the two chunks into one sorted chunk, we read from this queue. 6. Another bug, Bug#36444172 "Regression in 8.0.27+ related to Parallel DDL IO Amplification" read the sizes of the first two chunks from the queue and set a limit on the input buffer based on the size of the first two chunks. 7. In our case, the sizes of the first two chunks were smaller compared to the subsequent chunk sizes. 8. Therefore, while reading the rows from subsequent chunks we hit this imit on the input buffer. FIX: 1. Each ddl thread is allocated a certain amount of input buffer based on the number of scan threads and the DDL buffer size. We should use this allocation as the limit for the input buffer while reading the rows from a chunk. Change-Id: Iba4a224c9973bea2b5a6a2288a23473dd2c21b06
PreviousNext