Bug #115503 The sql_log_off parameter is not working as expected at the session level #578
Conversation
…t the session level When we modify a session variable, the changes should be reflected in the same session. The new privilege SESSION_VARIABLES_ADMIN controls the setting of certain variables, including sql_log_off. However, even after a user with the SESSION_VARIABLES_ADMIN privilege changes the session value of sql_log_off, the change is not applicable to the session unless the user also has additional admin privileges. To be precise, it appears that we are checking for the SUPER or CONNECTION_ADMIN privilege to turn off logging at the session level. This change address the issue by allowing users with SESSION_VARIABLES_ADMIN or SYSTEM_VARIABLES_ADMIN privilege to turn off logging at the session level, in addition to users with the SUPER privilege. This commit fixes the bug https://bugs.mysql.com/bug.php?id=115503 This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.
| Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
| I confirm the code being submitted is offered under the terms of the OCA signed by Amazon, and that I am authorized to contribute it. |
| Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
| Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
2 participants
When we modify a session variable, the changes should be reflected in the same session. The new privilege SESSION_VARIABLES_ADMIN controls the setting of certain variables, including sql_log_off. However, even after a user with the SESSION_VARIABLES_ADMIN privilege changes the session value of sql_log_off, the change is not applicable to the session unless the user also has additional admin privileges. To be precise, it appears that we are checking for the SUPER or CONNECTION_ADMIN privilege to turn off logging at the session level.
This change address the issue by allowing users with SESSION_VARIABLES_ADMIN or SYSTEM_VARIABLES_ADMIN privilege to turn off logging at the session level, in addition to users with the SUPER privilege.
This commit fixes the bug https://bugs.mysql.com/bug.php?id=115503
This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project.