Update net461 TFM to net462 #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
.NET Framework 4.6.1 support ended on 26 April 2022. Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
Dropping netcoreapp3.1 and net461 allows us to use the latest version. Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
Dropping net461 allows the latest version to be used. Signed-off-by: Bradley Grainger <bgrainger@gmail.com>
ViktorHofer reviewed Jan 1, 2023
| | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net461' OR '$(TargetFramework)' == 'net471' OR '$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'netstandard2.1' "> | ||
| <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" /> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net462' OR '$(TargetFramework)' == 'net471' OR '$(TargetFramework)' == 'netstandard2.0' OR '$(TargetFramework)' == 'netstandard2.1' "> |
There was a problem hiding this comment.
nit: it looks like you only want to bring this in for non .NETCoreApp. You can achieve that via the following condition:
'$(TargetFrameworkIdentifier)' != '.NETCoreApp'. That avoids the hardcoded tfms.
bgrainger added a commit that referenced this pull request Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #636.