Skip to content

Code Fix for issue #1 (Add support for adding attributes to the Velocity context) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mnesarco merged 1 commit into from
Mar 4, 2013
Merged

Code Fix for issue #1 (Add support for adding attributes to the Velocity context) #2

mnesarco merged 1 commit into from
Mar 4, 2013

Conversation

@zaherhammoud
Copy link
Contributor

@zaherhammoud zaherhammoud commented Mar 4, 2013

I have checked in the code related to the new proposed feature. Please review and let me know what you think.

Thanks,

Zaher Hammoud
@mnesarco
Copy link
Member

mnesarco commented Mar 4, 2013

This patch is very good. Thanks Zaher. I will apply it and then I will add a dependency to CGLIB for tests because of a known bug in mybatis-core-3.2.0 which mandates it at runtime. Once 3.2.1 is released I will remove the dependency again. Fix #1 and Close #2
mnesarco added a commit that referenced this pull request Mar 4, 2013
@mnesarco
Merge pull request #2 from zaherhammoud/master
32de745 
Code Fix for issue #1 (Add support for adding attributes to the Velocity context)
@mnesarco mnesarco merged commit 32de745 into mybatis:master Mar 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@zaherhammoud @mnesarco