Skip to content

Conversation

@qlp
Copy link
Contributor

@qlp qlp commented Jun 18, 2014

Test to demonstratie issue #224

(commit comment is incorrect, should be 2.6.9)

@qlp
Copy link
Contributor Author

qlp commented Jun 18, 2014

(Responding to message from Eduardo in closed pull request):

The problem with upgrading OGNL is that it is jarjarred and newer versions depends on Javassist so... it should be jarjarred also.

MyBatis jar will grow a lot, though this does not seem to be a big problem.

Taking advantage of that, we can also use the internal Javassist as the default proxy implementation (so cglib will not be needed, but you can still use if if you want).

I'm not sure what's best for MyBatis. Jarjaring a complex library like Javassist may be tricky? I don't know.

@emacarron
Copy link
Member

I have made some tests with 3.0.8 and to my surprise it works fine without javassist.

I have also had a look at OGNL sources and looks like javassist is used for compiling expressions, that sounds like a great improvement but we do not use it.

I dropped a mail to Lukasz Lenart. I hope he can confirm that Javassist dependency is optional and only for compilation.

@emacarron emacarron merged commit cc30d12 into mybatis:master Jun 21, 2014
@qlp qlp deleted the heavyinitialload branch June 21, 2014 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants