Update DynamicContext.java #173
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposal :
Removed trailing space on sql fragments since this alter the sql code that the user typed in the sqlmap file preventing the use of static text to be used as value, label or whatever the user might need it for.
Ex :
<sql id="bar">${@com.packacge.whatever.the.heck.this.might.be.Globals@BAR_TEXT}</sql> <select id="exemple"> select bar "bar end with <include refid="bar"/>" from foo where bar = '%<include refid="bar"/>' </select>This will fail since the space added at the sql fragment's end will corrupt the where filter (as well as the column title). This trailing space just alter the code the user did write and thus should be removed.
Cheers.