Add support for harnesses with parentLayers #161
Conversation
andytson-inviqa force-pushed the feature/parent-harness-layers branch 14 times, most recently from 0ac6d79 to 53c9104 Compare andytson-inviqa force-pushed the feature/parent-harness-layers branch from 53c9104 to ea61ca6 Compare andytson-inviqa force-pushed the feature/parent-harness-layers branch 3 times, most recently from db2ccee to 307d0fe Compare | tested against https://github.com/inviqa/harness-node-spa/releases/tag/0.2.0-rc1 and it worked |
src/Types/Workspace/Creator.php Outdated
| } | ||
| | ||
| $harnessYaml = file_get_contents($packageDir . '/harness.yml'); | ||
| exec('rm -rf ' . escapeshellarg($packageDir)); |
There was a problem hiding this comment.
This scares me somewhat
There was a problem hiding this comment.
I just wish PHP was another language where I could just import a archive system that can read the harness.yml directly from tarball stream
There was a problem hiding this comment.
PharData can do that, as with the tests but as can see nasty global storage it uses
There was a problem hiding this comment.
I'd have done that but I don't like that PharData can't mime detect file type, only read based on file extension, which is messy
There was a problem hiding this comment.
would the suggestions help?
There was a problem hiding this comment.
Sorry it was more the rm -rf aspect of it. It's likely safe but I get scared because of the incidents with Bumblebee & Steam for linux :)
andytson-inviqa force-pushed the feature/parent-harness-layers branch from 1c8e27c to a3657a8 Compare andytson-inviqa force-pushed the feature/parent-harness-layers branch from a3657a8 to 0f42945 Compare 
Resolves #72