Updated client logic for connecting to https endpoints #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the client connection logic to support HTTPS endpoints based on port detection. The changes enable the pgmanager CLI tool to automatically use HTTPS when connecting to servers on port 443.
Key Changes:
- Added automatic scheme detection (HTTP vs HTTPS) based on port 443
- Implemented host defaulting to "localhost" when the address starts with a colon
- Refactored URL construction to use parsed numeric port values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR updates the client connection logic to support HTTPS endpoints based on port detection. The changes enable the pgmanager CLI tool to automatically use HTTPS when connecting to servers on port 443.