Updated to remove map sync issue #12
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a concurrency issue in the Copy method of the Bind struct by adding proper synchronization when copying the internal vars map. The import statements are also reordered alphabetically.
- Adds read lock protection around the
varsmap access in theCopymethod using an immediately invoked function expression - Reorders import statements to place external packages before internal packages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| varsCopy := func() pgx.NamedArgs { | ||
| bind.RLock() | ||
| defer bind.RUnlock() | ||
| c := make(pgx.NamedArgs, len(bind.vars)+len(pairs)>>1) |
There was a problem hiding this comment.
The operator precedence in this expression is incorrect. The right shift operator >> has lower precedence than the addition operator +, so this evaluates as (len(bind.vars) + len(pairs)) >> 1 instead of the intended len(bind.vars) + (len(pairs) >> 1). This causes the map capacity to be calculated as half of the total, when it should be the number of existing vars plus half of the new pairs. Add parentheses to fix the operator precedence.
| c := make(pgx.NamedArgs, len(bind.vars)+len(pairs)>>1) | |
| c := make(pgx.NamedArgs, len(bind.vars)+(len(pairs)>>1)) |
1 participant
This PR addresses a concurrency issue in the Copy method of the Bind struct by adding proper synchronization when copying the internal vars map. The import statements are also reordered alphabetically.