Skip to content

Conversation

djthorpe
Copy link
Member

@djthorpe djthorpe commented Sep 7, 2025

This PR modernizes the codebase by migrating from experimental packages to Go standard library equivalents and performs general code cleanup. The changes primarily update imports and fix time comparison logic while removing unused CLI components.

  • Replaces golang.org/x/exp/maps with standard maps package
  • Updates maps.Values() and maps.Keys() calls to use slices.Collect() wrapper
  • Fixes time comparison using Equal() method instead of direct equality
  • Removes extensive CLI-related code and dependencies
@Copilot Copilot AI review requested due to automatic review settings September 7, 2025 06:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the codebase by migrating from experimental packages to Go standard library equivalents and performs general code cleanup. The changes primarily update imports and fix time comparison logic while removing unused CLI components.

  • Replaces golang.org/x/exp/maps with standard maps package
  • Updates maps.Values() and maps.Keys() calls to use slices.Collect() wrapper
  • Fixes time comparison using Equal() method instead of direct equality
  • Removes extensive CLI-related code and dependencies

Reviewed Changes

Copilot reviewed 20 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/homeassistant/services.go Updates imports and wraps maps.Values() with slices.Collect()
pkg/homeassistant/events.go Formats import statement with package comment
pkg/homeassistant/README.md Improves markdown formatting for URL references
go.mod Removes golang.org/x/exp dependency and cleanup unused requires
cmd/api/homeassistant.go Updates imports and wraps maps.Keys() with slices.Collect()
cmd/api/install.go Fixes time comparison using Equal() method
etc/_cli/*.go Removes entire CLI command infrastructure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@djthorpe djthorpe self-assigned this Sep 7, 2025
@djthorpe djthorpe merged commit 4fdf890 into main Sep 7, 2025
3 checks passed
@djthorpe djthorpe deleted the djt-0907-cleanup branch September 7, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant