Articulation tweaks

[mike-spa]

Three separate jobs:

• A small modification of default styles.
• Correcting the alignment of composite staccato/tenuto marks.
• Improving the efficiency when fetching the category of a given articulation mark (it doesn't makes sense to perform all those comparisons every time we need to query it, makes more sense to compute them once and store them).

Before:

After:

[cbjeukendrup]

To reduce memory usage, you could store these using a single field of flags. But I'd first ask @vpereverzev if he thinks that's better.

Anyway, to do that, you would create an enum like this:

enum class ArticulationCategory: char { // char makes sure that this will use only 1 byte,  // which consists of 8 bits,  // which is enough to store these 6 flags None = 0x00 Double = 0x01 Tenuto = 0x02 Staccato = 0x04 Accent = 0x08 Marcato = 0x10 LuteFingering = 0x20 }

Then create a Flags from that enum: (you need to #include "flags.h" for this)

DECLARE_FLAGS(ArticulationCategories, ArticulationCategory) DECLARE_OPERATORS_FOR_FLAGS(ArticulationCategories)

Then replace all these members with:

Suggested change

	bool _isDouble = false;
	bool _isTenuto = false;
	bool _isStaccato = false;
	bool _isAccent = false;
	bool _isMarcato = false;
	bool _isLuteFingering = false;
	ArticulationCategories m_categories = ArticulationCategory::None;

Then replace the is... methods with:

 bool isDouble() const { return m_categories & ArticulationCategory::Double; }

etc.

Then modify computeCategories like this:

m_categories.setFlag(ArticulationCategory::Double, _symId == SymId::articMarcatoStaccatoAbove || _symId == SymId::articMarcatoStaccatoBelow || _symId == SymId::articTenutoStaccatoAbove || …)

[mike-spa]

Thanks! I'll try!

[cbjeukendrup]

const got lost here :)