[Fab] Remove no longer necessary span wrapper #27112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
siriwatknp added breaking change 
This comment has been minimized.
This comment has been minimized.
eps1lon approved these changes Jul 5, 2021
oliviertassinari changed the title label Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Breaking changes
[Fab] Remove no longer necessary span wrapper
button > span > childrenexists as a workaround for flex container bug on button BUT not anymore, so this PR remove the span.✅ Chrome 83+ (latest 90)
✅ Safari 11+ (latest 14)
✅ Edge
✅ Firefox 63 (latest 89)
https://github.com/philipwalton/flexbugs#flexbug-9