[BottomNavigation] Remove wrapper from BottomNavigationAction #26923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
siriwatknp added the scope: bottom navigation 
siriwatknp added the breaking change 
Comment on lines 550 to 552
| ### BottomNavigationAction | ||
| | ||
| - `span` element that wraps children has been removed. `wrapper` classKey is also removed. More details about [this change](https://github.com/mui-org/material-ui/pull/26666). |
Member
There was a problem hiding this comment.
Suggested change
| ### BottomNavigationAction | |
| - `span` element that wraps children has been removed. `wrapper` classKey is also removed. More details about [this change](https://github.com/mui-org/material-ui/pull/26666). | |
| - Remove the `span` element that wraps the children. Remove the `wrapper` classKey too. More details about [this change](https://github.com/mui-org/material-ui/pull/26666). |
Member
There was a problem hiding this comment.
No objections to reverse the approach, one header by React component instead of UI component, but maybe the change should be done all at once, in a batch 🤷♂️
oliviertassinari changed the title wrapper from BottomNavigationActionwrapper from BottomNavigationAction 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
mnajdova reviewed Jun 25, 2021
| +<BottomNavigation onChange={(event: React.SyntheticEvent) => {}} /> | ||
| ``` | ||
| | ||
| - Remove the `span` element that wraps the children. Remove the `wrapper` classKey too. More details about [this change](https://github.com/mui-org/material-ui/pull/26666). |
Member
There was a problem hiding this comment.
I think it's confusing linking different PR here. Let's update the current PR descirption with the details of why the changes was introduced and link this PR in the migration guide.
mnajdova approved these changes Jun 25, 2021
Member
mnajdova left a comment
mnajdova left a comment There was a problem hiding this comment.
See one comment before merging. Apart from that looks great 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
[BottomNavigation] Remove wrapper from BottomNavigationAction ([BottomNavigation] Remove
wrapperfrom BottomNavigationAction #26923) @siriwatknpspanelement that wraps children has been removed.wrapperclassKey is also removed. More details about this change.WHY the wrapper is removed
button > span > childrenexists as a workaround for flex container bug on button BUT not anymore, so this PR remove the span.https://github.com/philipwalton/flexbugs#flexbug-9
fix one of breaking changes #20012.
Preview: https://deploy-preview-26923--material-ui.netlify.app/components/bottom-navigation/