allow stream ponyfill as ReadableStream #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #67 +/- ## ========================================== + Coverage 96.89% 97.89% +0.99% ========================================== Files 15 15 Lines 902 902 Branches 183 182 -1 ========================================== + Hits 874 883 +9 + Misses 28 19 -9
Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
object instanceof ReadableStreamdoes not allow ponyfills, a clone of built-in class, so it takes other ways.In addition, this PR also supports a newer feature
ReadableStream.prototype[@@asyncIterator], which is supported by no browser as of June 2019.