Source node from string with map #50
Conversation
| This is not ready to be merged.... |
| This looks great, remember to add documentation in the readme for the new method! Let me know when it is ready. |
lib/source-map/source-node.js Outdated
There was a problem hiding this comment.
Nit: please add a space between if and (, as well as while and ( below and in the rest of the file. Thanks!
| rebased, style fixed and documentation added. |
| I only thought it wasn't ready because I tried with coffee-script SourceMap und the result was weird. But it was only weird, because coffee-script SourceMaps are weird. I've written a little visulization tool to view SourceMaps uglify-js produces nice mappings, but TypeScript has the best mappings. coffee-script has weird mappings. CoffeeScriptRedux has weird mappings and a original column offset of 1. @michaelficarra There is a "Minimize" button, which minimizes the source with uglify-js and combines the SourceMaps. (best to test it with TypeScript). |
test/source-map/test-source-node.js Outdated
There was a problem hiding this comment.
So I know you authored this before it existed, but can you use util.assertEqualMaps here instead of all of these separate asserts? Also, for if you write more tests in the future, we can't use deepEqual in the tests because we haven't shimmed it for Firefox's xpcshell tests. If you haven't seen it, I added a list of the methods you can use in the README under the tests section.
| Thanks a lot! Will merge this in as soon as the one thing is taken care of. |
| done |
| Thanks! |
| You didn't merged sokra/source-map@8e7d033... |
| Argh I was wondering why github wasn't marking it merged. Forgot to fetch before I merged. Thanks again! |
| 😄 |
2 participants
This pull request is based on #46 and #47.
It added a method SourceNode.fromStringWithSourceMap.
It converts a SourceMap into a SourceNode. It's useful if embedding other files that already bring a SourceMap.
This is an optional step 3 for composing SourceMaps.