Source map gen apply map #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Nit: please add @param documentation comments.
Contributor
| We also need tests and documentation for |
I incorrectly assumed that mappings automatically end with new lines in the generated source.
Contributor Author
| rebased, documenation and test Also found a bug in my previous commit... |
Contributor
There was a problem hiding this comment.
Nit: s/Than/Then/ :)
Also, while we're at it, these two sentences can be combined into one sentence: "Check if it can be mapped by the source map, then update the mapping."
Contributor
| Ok so I just had a total brain fart (it's been a long day) and merged, pushed, and published this code. Luckily the only changes I requested are largely aesthetic, would you please submit them as a new pull request? Thank you very much! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request is based on #46 and #47.
It added a method SourceMapGenerator.applySourceMap.
It allows to merge a SourceMap for a source file into a SourceMapGenerator.
This is step 2 for composing SourceMaps.