Update WASM binary and Land WASM rust sources in this repository #465

ochameau · 2022-10-18T15:19:50Z

Today, the rust sources used to generate lib/mappings.wasm are hosted on:
https://github.com/fitzgen/source-map-mappings/
This looks unofficial, whereas that's where the sources come from and last binary was built from that repo.

It would be easier to fold the rust sources in this repo to ease contributions to it, while increasing visibility to the rust sources.

While we are at landing sources in-tree, it would also be nice to refresh the wasm binary by building it with latest rust version.
The current binary has been being in 2018 and is no longer reproducible.

In an effort to help reproduce the same wasm file, here is the environment from which I built it:

$ cargo -V cargo 1.64.0 (387270bc7 2022-09-16) $ rustup -V rustup 1.25.1 (bb60b1e89 2022-07-12) info: This is the version for the rustup toolchain manager, not the rustc compiler. info: The currently active `rustc` version is `rustc 1.64.0 (a55dd71d5 2022-09-19)`

Using instruction documented here.

coveralls · 2022-10-18T15:23:16Z

Pull Request Test Coverage Report for Build 607

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.713%

Totals
Change from base Build 606:	0.0%
Covered Lines:	827
Relevant Lines:	911

💛 - Coveralls

coveralls · 2022-10-18T15:23:16Z

Pull Request Test Coverage Report for Build 613

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.713%

Totals
Change from base Build 606:	0.0%
Covered Lines:	827
Relevant Lines:	911

💛 - Coveralls

hybrist

RSLGTM on the Rust and Python code (assuming that it's just copying existing work). Left some questions in metadata files and license updates.

hybrist · 2022-10-18T15:29:31Z

wasm-mappings/.gitattributes

@@ -0,0 +1,2 @@
+README.md -diff -merge


Is this redundant with the top-level attributes?

Oh yes I forgot to remove it after folding it into the main one.

hybrist · 2022-10-18T15:29:50Z

wasm-mappings/.travis.yml

@@ -0,0 +1,27 @@
+language: rust


Should this be removed?

hybrist · 2022-10-18T15:31:02Z

wasm-mappings/LICENSE-APACHE

@@ -0,0 +1,201 @@
+ Apache License


Should the top-level LICENSE file be updated to ensure people are aware of the mixed licensing that applies to the repo?

Semi-related: Should we reach out to Nick and Tom to check if relicensing to BSD is in the cards (not for this CL but in the near future)? I assume it's a single-ish author so far which makes it still relatively easy.

I'll reach out before landing. I suspect they changed the main repo license without changing the wasm one.

I am happy to relicense the rust code as BSD.

Thanks a lot for chiming in Nick!

ochameau · 2022-10-18T15:59:09Z

RSLGTM on the Rust and Python code (assuming that it's just copying existing work).

Yes I copied master branch as is.

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau · 2022-10-19T07:55:12Z

I removed the license files from wasm folder, updated various files to mention BSD license, and updated github repo reference to mozilla's source-map one.

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

bomsy · 2022-10-19T09:57:02Z

CONTRIBUTING.md

+Move to wasm sources folder:

 ```
 $ git clone https://github.com/fitzgen/source-map-mappings.git


Should this line be removed now that we have the mappings in this repo?

yes, forgot to remove the command line!

bomsy · 2022-10-19T10:06:36Z

wasm-mappings/CONTRIBUTING.md

+# Contributing to `source-map-mappings`
+
+Hi! We'd love to have your contributions! If you want help or mentorship, reach
+out to us in a GitHub issue, or ping `fitzgen` in [#rust on irc.mozilla.org](irc://irc.mozilla.org#rust)


Is this irc channel still valid?

irc server is down, I removed it with the new matrix channel.

bomsy · 2022-10-19T10:08:46Z

wasm-mappings/README.md

@@ -0,0 +1,33 @@
+# `source-map-mappings`


Sould this become wasm-mappings?

No, the rust package name is still source-map-mappings (you can see it referenced in cargo files)

bomsy

LGTM! Just had comments/questions about documentation updates
Thanks

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau · 2022-10-19T10:40:38Z

I've also updated the patch to ensure using latest master revision of source-map-mappings.
So that we are using fitzgen/source-map-mappings@197660f here, with the few cleanups and renames.

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau · 2022-10-20T17:11:51Z

With the latest changeset refreshing the wasm binary with latest version of rust, there seem to be a significant performance improvement:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=340b70fc0526e767e8657b8f41749240d14d2908&originalSignature=4081483&newSignature=4081483&framework=12&originalRevision=b4fda98f266ca9b53c8f3962d6e92a9d68e32b57&page=1&showOnlyImportant=1

(I ported the existing perf test from bench folder to firefox CI)

eemeli

Looks good, provided that the contribution guidelines and the README link to them is fixed.

eemeli · 2022-10-21T07:11:30Z

wasm-mappings/CONTRIBUTING.md

@@ -0,0 +1,87 @@
+# Contributing to `source-map-mappings`


The contents of this file should be merged into the root CONTRIBUTING.md. It's not really tenable to e.g. apply a separate CoC to a part of a repo as this implies.

I dropped the redundant content, but kept it for wasm specifics instructions.
I may consider moving "updating mappings.wasm" here?
I find it nice to keep the rust/wasm part of the codebase still contained in this subfolder.

Yeah, that makes sense.

wasm-mappings/src/lib.rs

wasm-mappings/README.tpl

ochameau · 2022-10-25T12:26:47Z

When testing against Babel and React sourcemaps there is also significant improvements when running on Firefox:

Up to 20% faster when parsing the babel sourcemap and between 5% to 7% faster on mapping generated to original locations.

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

The WASM sources used to be hosted on another personal repo: https://github.com/fitzgen/source-map-mappings/ This patch inlines this repo into wasm-mappings folder so that it is easier to contribute to WASM sources and see the impact of modifications made to it. This also clarify what are the sources of the binary wasm file (lib/mappings.wasm). I picked current master branch revision: 197660faf3dd1167c643797a5ed62cb687482c54. This isn't a straight merge of the original repo changeset. License has been changed to BSD3, readme template has been dropped, documentation has been updated and references to source-map-mappings have been revised.

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

The last generated wasm file was built in 2018 and it is very challenging to rebuild it the exact same. Rebuild it using latest rust binary and libraries: cargo 1.64.0 (387270bc7 2022-09-16) rustc 1.64.0 (a55dd71d5 2022-09-19) rustup 1.25.1 (bb60b1e89 2022-07-12)

ochameau · 2022-11-02T15:13:52Z

I had to request the enabling of actions-rs/toolchain@v1 on mozilla repos for the wasm github actions:
https://bugzilla.mozilla.org/show_bug.cgi?id=1797457
Otherwise the github actions for wasm were failing on rust tests.

Now everything is green and good to go!

hybrist approved these changes Oct 18, 2022

View reviewed changes

ochameau force-pushed the wasm-sources branch from 07e01d8 to 2e14554 Compare October 18, 2022 15:47

ochameau requested a review from bomsy October 18, 2022 17:57

ochameau added a commit to ochameau/source-map that referenced this pull request Oct 19, 2022

Relicense source-map-mappings to BSD.

4a5bdb5

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau force-pushed the wasm-sources branch from 2e14554 to 9f6ce5d Compare October 19, 2022 07:54

ochameau added a commit to ochameau/source-map that referenced this pull request Oct 19, 2022

Relicense source-map-mappings to BSD.

2963e57

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau force-pushed the wasm-sources branch from 9f6ce5d to a0155da Compare October 19, 2022 08:07

bomsy reviewed Oct 19, 2022

View reviewed changes

bomsy approved these changes Oct 19, 2022

View reviewed changes

ochameau added a commit to ochameau/source-map that referenced this pull request Oct 19, 2022

Relicense source-map-mappings to BSD.

157bb17

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau force-pushed the wasm-sources branch from a0155da to 066357e Compare October 19, 2022 10:34

ochameau added a commit to ochameau/source-map that referenced this pull request Oct 19, 2022

Relicense source-map-mappings to BSD.

aec646f

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau force-pushed the wasm-sources branch from 066357e to 22bae06 Compare October 19, 2022 11:12

This was referenced Oct 19, 2022

Is this repo really open source ? #451

Closed

Where is the source of mappings.wasm? #387

Closed

eemeli approved these changes Oct 21, 2022

View reviewed changes

ochameau added a commit to ochameau/source-map that referenced this pull request Oct 25, 2022

Relicense source-map-mappings to BSD.

7e6bc64

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau force-pushed the wasm-sources branch from 5cb1a10 to 272d713 Compare October 25, 2022 12:48

ochameau force-pushed the wasm-sources branch from 272d713 to 9ad8fa3 Compare November 2, 2022 13:56

ochameau added 2 commits November 2, 2022 07:03

Relicense source-map-mappings to BSD.

5c7822b

Following agreement from Nick on mozilla#465, align source-map-mappings with source-map license.

ochameau added 2 commits November 2, 2022 07:03

Add github actions to cover wasm sources.

7c14a86

ochameau force-pushed the wasm-sources branch from 9ad8fa3 to b56a5c7 Compare November 2, 2022 14:03

ochameau merged commit 56c1617 into mozilla:master Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update WASM binary and Land WASM rust sources in this repository #465

Update WASM binary and Land WASM rust sources in this repository #465

Uh oh!

ochameau commented Oct 18, 2022

coveralls commented Oct 18, 2022

coveralls commented Oct 18, 2022 •

edited

Loading

hybrist left a comment

hybrist Oct 18, 2022

ochameau Oct 18, 2022

hybrist Oct 18, 2022

hybrist Oct 18, 2022

ochameau Oct 18, 2022 •

edited

Loading

fitzgen Oct 18, 2022

ochameau Oct 19, 2022

ochameau commented Oct 18, 2022

ochameau commented Oct 19, 2022

bomsy Oct 19, 2022 •

edited

Loading

ochameau Oct 19, 2022

bomsy Oct 19, 2022

ochameau Oct 19, 2022

bomsy Oct 19, 2022

ochameau Oct 19, 2022

bomsy left a comment

ochameau commented Oct 19, 2022

ochameau commented Oct 20, 2022

eemeli left a comment

eemeli Oct 21, 2022

ochameau Oct 25, 2022

eemeli Oct 25, 2022

Uh oh!

Uh oh!

ochameau commented Oct 25, 2022

ochameau commented Nov 2, 2022

Labels

6 participants

Update WASM binary and Land WASM rust sources in this repository #465

Update WASM binary and Land WASM rust sources in this repository #465

Uh oh!

Conversation

ochameau commented Oct 18, 2022

coveralls commented Oct 18, 2022

Pull Request Test Coverage Report for Build 607

💛 - Coveralls

coveralls commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 613

💛 - Coveralls

hybrist left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ochameau Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ochameau commented Oct 18, 2022

ochameau commented Oct 19, 2022

bomsy Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bomsy left a comment

Choose a reason for hiding this comment

ochameau commented Oct 19, 2022

ochameau commented Oct 20, 2022

eemeli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ochameau commented Oct 25, 2022

ochameau commented Nov 2, 2022

Labels

6 participants

coveralls commented Oct 18, 2022 •

edited

Loading

ochameau Oct 18, 2022 •

edited

Loading

bomsy Oct 19, 2022 •

edited

Loading