Add support in SourceMapConsumer for indexed source maps #127
Conversation
There was a problem hiding this comment.
Rather than sort it ourselves, we should assert that they are ordered correctly and throw an error with a helpful message if they aren't.
| Thanks for the PR! There's some work to do, but we're going in the right direction. Ping me when you've made the requested updates. |
There was a problem hiding this comment.
Nitpick: Capitalize and punctuate comments, please.
| @fitzgen Okay, I've resolved all the TODOs, and this should be ready to go. Sorry for the huge lag time! It looks like this has diverged a bit from master. How would you like me to merge the results, or would you like to handle that? |
| @fitzgen Ping? |
There was a problem hiding this comment.
Nit: Can we make this bit of if-string-then-strip-prefix-and-json-parse stuff a helper function in util since it is in two places now?
There was a problem hiding this comment.
I don't understand what this replacement is about, so I'm not sure what I'd name that function
| Thanks for the great work here! This looks good. Can you please rebase onto the latest master + fix up based on the final comments I had? Then I will merge! |
jlfwong force-pushed the jlfwong-indexed-source-map branch from 592b6ef to 3d512cd Compare | Doing a literal rebase proved crazy because of all the code flux since I opened this PR, so I just started from current master and ported my changes. I think I've addressed all the concerns except the ones I commented on (rebasing makes it hard to follow the comments though). Unless there are significant blocking changes, I'd really appreciate merging this and dealing with minor issues in a later diff - keeping a diff this large up to date is tricky! |
| Thanks! I've merged the PR and published a new version to npm. |
2 participants
Fixes #16 (or at least the consumption part of it)
This is a WIP, but consumption of indexed source maps seems to be working. Let me know if you see anything going complete the wrong way, or if there are additional things that need implementing that I'm missing.
I'm not totally sure where the documentation for each of the functions should live - should I create stub functions on
SourceMapConsumer.prototypethat just throw errors saying they must be overridden, and place the documentation there? Or is it okay to duplicate the documentation betweenBasicSourceMapConsumerandIndexedSourceMapConsumer?