new uploads for a pending version inherit the nomination date #4959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
diox reviewed Mar 17, 2017
| return | ||
| addon = instance.addon | ||
| if (instance.nomination is None and | ||
| addon.status in amo.UNREVIEWED_ADDON_STATUSES and not |
Member
There was a problem hiding this comment.
Was this particular condition the cause of the problem? Since inherit_nomination() is called on post_save, it feels weird to keep that condition in there and manually call a different method to fix this issue.
Member Author
There was a problem hiding this comment.
I looked into it, and the call from addons.models.watch_status, but taking it out only created test fails. The problem is, with updates, we don't want the version to inherit the nomination date of the original approval, or previous approved updates. I can't see how it ever worked with updates tbh.
If anything I'm tempted to remove the inherit_nomination calls from post_save and watch_status and only have it set in handle_upload
diox approved these changes Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes mozilla/addons#4074
After a lot of trial and error this is a minimal change that doesn't try to touch the circular logic used for
status=AMO_NOMINATEDadd-ons. It possibly should but there are a surprising number of tests for existing code that start to break. (could be a follow-up)