Add additional custom confusable characters to normalization code #24181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The custom table is moved so that the translation happens earlier, because some of these are symbols that would otherwise be stripped by the normalization code.
diox requested review from a team and eviljeff and removed request for a team 
eviljeff approved these changes Nov 24, 2025
Member
eviljeff left a comment
eviljeff left a comment There was a problem hiding this comment.
There should probably be an issue too - at least for QA to verify against. (this PR, and the resulting commit are public now anyway, so we don't gain much by only having the private jira ticket)
Member Author
| The JIRA ticket was filed by QA 😅 - I can file a public one but then it makes the sprint messy - and I'd like the actual strings QA is using for testing to stay private, even if the characters we're adding are public. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The custom table is moved so that the translation happens earlier, because some of these are symbols that would otherwise be stripped by the normalization code.
Fixes https://mozilla-hub.atlassian.net/browse/AMOENG-2124