Skip to content

Conversation

@eviljeff
Copy link
Member

@eviljeff eviljeff commented Oct 6, 2025

Fixes: mozilla/addons#15849

Description

Removes all MAD scanner integration in addons-server

Context

There are three database columns (two already null-able; one with a migration to make it null-able) that will need removing in a subsequent push.

Testing

Shouldn't be necessary, but you could:

  • upload an xpi so scanners run (now without mad)
  • access reviewer tools (mad review queue is gone)
  • load a review page and perform an action that would have clear the mad flag (e.g. approve a version)

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
  • Add before and after screenshots (Only for changes that impact the UI).
  • Add or update relevant docs reflecting the changes made.
@eviljeff eviljeff marked this pull request as ready for review October 7, 2025 10:41
@eviljeff eviljeff requested review from diox and willdurand and removed request for diox October 7, 2025 10:41
@willdurand
Copy link
Member

There are three database columns (two already null-able; one with a migration to make it null-able) that will need removing in a subsequent push.

Do we already have a ticket for that?

@eviljeff
Copy link
Member Author

There are three database columns (two already null-able; one with a migration to make it null-able) that will need removing in a subsequent push.

Do we already have a ticket for that?

mozilla/addons#15887

Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More red than green award, congratulations!

@eviljeff eviljeff merged commit 8a35dce into mozilla:master Oct 13, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants