Run scanner query rules using replica, not primary db #23944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Only use the primary to grab the rule to make sure it exists when we try to get it.
willdurand approved these changes Sep 23, 2025
Member Author
| @willdurand your comment gave me another idea to improve this, I've added 4cef52b which includes a test for the new method I'm adding for this. Can you re-review ? |
willdurand approved these changes Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Only use the primary to grab the rule to make sure it exists when we try to get it.
Fixes mozilla/addons#15850
Description
Now that we have more workers for the tasks routed to the
zadminqueue like the scanners query rule tasks, we're causing a bunch of parallel connections to the primary db, which isn't ideal, we want the load to be distributed better.This might not be enough to fix it, we might need to make getting the rule use a replica too, but this should be a safe&quick fix to try first.
Testing
Can't be tested with a regular development environment. You can check that a simple scanner query rule still executes but unless you add a database replica you won't be able to test the change itself locally.