Prevent request.user from being evaluated in middlewares #18913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When dealing with a request with auth credentials, GraphiteMiddleware's default implementation forces request.user to be evaluated to send a `response.auth` statsd ping, causing a database query even if the view didn't use auth at all. We don't need that ping, so replace the middleware with a custom one that doesn't do this, avoiding the database query in those cases.
diox requested review from a team and bobsilverberg and removed request for a team 
bobsilverberg approved these changes Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When dealing with a request with auth credentials,
GraphiteMiddleware's default implementation forcesrequest.userto be evaluated to send aresponse.authstatsd ping, causing a database query even if the view didn't use auth at all. We don't need that ping, so replace the middleware with a custom one that doesn't do this, avoiding the database query in those cases.Fixes mozilla/addons#8693